Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add a dedicated page for tests with more information #3019

Merged
merged 9 commits into from Jan 24, 2023
Merged

docs: add a dedicated page for tests with more information #3019

merged 9 commits into from Jan 24, 2023

Conversation

georglauterbach
Copy link
Member

@georglauterbach georglauterbach commented Jan 22, 2023 •
edited

Description

The title says it all. If you want to adjust this PR, please just go ahead, you needn't provide a suggestion :)

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@georglauterbach georglauterbach added kind/improvement Improve an existing feature, configuration file or the documentation area/documentation labels Jan 22, 2023
@georglauterbach georglauterbach added this to the v12.0.0 milestone Jan 22, 2023
@georglauterbach georglauterbach self-assigned this Jan 22, 2023
wernerfred
wernerfred previously approved these changes Jan 22, 2023
View reviewed changes
Copy link
Member

@wernerfred wernerfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for rewriting this ✍🏻 Much clearer now 💡 Will approve as i see nothing wrong and stylish things are a never ending thing in documentation 😄

docs/content/contributing/tests.md Outdated Show resolved Hide resolved
wernerfred
wernerfred previously approved these changes Jan 23, 2023
View reviewed changes
polarathene
polarathene requested changes Jan 24, 2023
View reviewed changes
docs/content/contributing/tests.md Outdated Show resolved Hide resolved
docs/content/contributing/tests.md Outdated Show resolved Hide resolved
docs/content/contributing/tests.md Outdated Show resolved Hide resolved
docs/content/contributing/tests.md Outdated Show resolved Hide resolved
docs/content/contributing/tests.md Outdated Show resolved Hide resolved
docs/content/contributing/tests.md Outdated Show resolved Hide resolved
docs/content/contributing/tests.md Outdated Show resolved Hide resolved
docs/content/contributing/tests.md Outdated Show resolved Hide resolved
docs/content/contributing/tests.md Outdated
...
```

[//]: # (Links)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? Is this doing anything in particular?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a markdown comment; I can remove it though.

docs/content/index.md Outdated Show resolved Hide resolved
@georglauterbach @polarathene
Apply suggestions from code review
7d626f3 
Co-authored-by: Brennan Kinney <5098581+polarathene@users.noreply.github.com>
polarathene
polarathene requested changes Jan 24, 2023
View reviewed changes
docs/content/contributing/tests.md Outdated Show resolved Hide resolved
docs/content/contributing/tests.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Documentation preview for this PR is ready! 🎉

Built with commit: 600cc1c

@georglauterbach georglauterbach merged commit 7eeb9c3 into master Jan 24, 2023
@georglauterbach georglauterbach deleted the docs/tests branch January 24, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polarathene polarathene polarathene approved these changes

@wernerfred wernerfred wernerfred approved these changes

@casperklein casperklein Awaiting requested review from casperklein

Assignees

@georglauterbach georglauterbach

Labels
area/documentation kind/improvement Improve an existing feature, configuration file or the documentation
Projects
None yet
Milestone
v12.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@georglauterbach @polarathene @wernerfred @casperklein