Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove CI ENV & disable fail-fast #3065

Merged
merged 1 commit into from Feb 6, 2023
Merged

Conversation

georglauterbach
Copy link
Member

Description

  1. BATS will actaully correctly determine that it is running in a CI environment, so we can omit the CI variable (not needed at all) (see a run in a fork if mine: https://github.com/georglauterbach/docker-mailserver/actions/runs/4103019817/jobs/7076744395)
  2. When a current test is failing, all other parallel jobs are stopped by GH actions due to their fail-fast approach. While this is nice for many use cases, it's not in our case - so I disabled it. Now, all tests are running to completion.

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

1. BATS will actaully correctly determine that it is running in a CI
   environment, so we can omit the `CI` variable (not needed at all)
2. When a current test is failing, all other parallel jobs are stopped
   by GH actions due to their fail-fast approach. While this is nice for
   many use cases, it's not in our case - so I disabled it. Now, all
   tests are running to completion.
@georglauterbach georglauterbach added area/ci kind/improvement Improve an existing feature, configuration file or the documentation labels Feb 6, 2023
@georglauterbach georglauterbach added this to the v12.0.0 milestone Feb 6, 2023
@georglauterbach georglauterbach self-assigned this Feb 6, 2023
@georglauterbach georglauterbach merged commit 4efbbbe into master Feb 6, 2023
@georglauterbach georglauterbach deleted the ci/adjustments branch February 6, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci kind/improvement Improve an existing feature, configuration file or the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants