Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add information to Logwatch's mailer so Envelope From is properly set #3081

Merged
merged 2 commits into from Feb 18, 2023
Merged

fix: add information to Logwatch's mailer so Envelope From is properly set #3081

merged 2 commits into from Feb 18, 2023

Conversation

georglauterbach
Copy link
Member

@georglauterbach georglauterbach commented Feb 9, 2023 •
edited

Description

I came across this when looking at Rspamd logs. Logwatch does not set the "Envelope From" header properly and the return path is also wrong (it uses root@mail.<DOMAINNAME>).

With the new addition, the correct header is set as specified in LOGWATCH_SENDER.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@georglauterbach
add information so Envelope From is properly set
403a231 
I came across this when looking at Rspamd logs. Logwatch does not send
the "Envelope From" header properly and the return path is also wrong
(it uses `root@mail.<DOMAINNAME>`).

With the new addition, the correct header is set as specified in
`LOGWATCH_SENDER`.
@georglauterbach georglauterbach added this to the v12.0.0 milestone Feb 9, 2023
@georglauterbach georglauterbach self-assigned this Feb 9, 2023
@georglauterbach georglauterbach changed the title fix: add information to Logwatch#s mailer so Envelope From is properly set fix: add information to Logwatch's mailer so Envelope From is properly set Feb 11, 2023
@georglauterbach georglauterbach merged commit 632012a into master Feb 18, 2023
@georglauterbach georglauterbach deleted the fix/logwatch-envelope-from branch February 18, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polarathene polarathene polarathene approved these changes

@casperklein casperklein Awaiting requested review from casperklein

Assignees

@georglauterbach georglauterbach

Labels
area/configuration (file)
Projects
None yet
Milestone
v12.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@georglauterbach @polarathene