Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SRS setup #3158

Merged
merged 13 commits into from Mar 12, 2023
Merged

fix: SRS setup #3158

merged 13 commits into from Mar 12, 2023

Conversation

casperklein
Copy link
Member

@casperklein casperklein commented Mar 5, 2023 •
edited

Description

This PR refactores the SRS setup, while fixing #3144 (comment)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein self-assigned this Mar 5, 2023
@casperklein casperklein added this to the v12.0.0 milestone Mar 5, 2023
@casperklein casperklein marked this pull request as ready for review March 5, 2023 21:33
@casperklein casperklein requested a review from a team March 5, 2023 21:33
@casperklein casperklein marked this pull request as draft March 5, 2023 21:53
@casperklein casperklein marked this pull request as ready for review March 5, 2023 22:03
@casperklein casperklein mentioned this pull request Mar 5, 2023
Merged
7 tasks
georglauterbach
georglauterbach approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@georglauterbach georglauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@georglauterbach georglauterbach changed the title Fix SRS setup fix: SRS setup Mar 6, 2023
polarathene
polarathene approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 😁

@casperklein casperklein merged commit 2da3e1b into docker-mailserver:master Mar 12, 2023
7 checks passed
@casperklein casperklein deleted the fix-srs branch March 12, 2023 11:10
@polarathene polarathene mentioned this pull request Jan 21, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polarathene polarathene polarathene approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@casperklein casperklein

Labels
area/scripts priority/high
Projects
None yet
Milestone
v12.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@casperklein @polarathene @georglauterbach