scripts: disallow alias = account #3270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not support aliases that are accounts at the same time. This commit provides a guard that checks the condition.
13 tasks
|
@polarathene I am not 100% certain whether we should disallow both directions, but to me that makes sense. |
polarathene
requested changes
Apr 17, 2023
polarathene
approved these changes
Apr 17, 2023
casperklein
reviewed
Apr 18, 2023
| @@ -74,6 +74,10 @@ function _arg_expect_mail_account | |||
| function _account_should_not_exist_yet | |||
| { | |||
| __account_already_exists && _exit_with_error "'${MAIL_ACCOUNT}' already exists" | |||
| if grep -q "^${MAIL_ACCOUNT}" "${DATABASE_VIRTUAL}" | |||
There was a problem hiding this comment.
I remember, that we had a similar issue in the past:
postfix-virtual.cf looks like:
myalias@example.com user@example.com
The grep statement above would also match on:
Adding a space for example should fix it:
if grep -q "^${MAIL_ACCOUNT} " "${DATABASE_VIRTUAL}"
There was a problem hiding this comment.
That should be handled in both lookups then? But for accounts table, instead of space a |?
10 tasks
ghost
mentioned this pull request
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We do not support aliases that are accounts at the same time. This commit provides a guard that checks the condition.
@bibiak1 made us aware of the fact that we allow creating aliases as users (and vice versa). I think we do not support this, and at least to me, it does not make a lot of sense.
Fixes #3262
Closes #3259
Type of change
Checklist: