New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/misc: update to align with Docker Compose v2 #3295
Conversation
Payed attention to rename to `Docker Compose` where it was used as a proper noun.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
- May want to use upstream preferred
compose.yaml
convention. - May want to revise a comment regarding
volumes_from
.
I also added a short note about the new Docker Compose V2 specification at the top of the Usage page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 😁
INFO: Marked this with |
I am unsure about the renaming of |
Just in case you missed them, I unresolved the earlier review feedback for visibility. It quotes Docker docs that from July 2023 they're encouraging Other projects may not be aware of that, or may not see any reason to adjust. You'll likely see a mix with time, we can do our part, but it's not mandatory.
We have had confusion over dropping the Once Docker updates their docs later this year, they'll be using Up to you, but as long as our docs make mention about V2 along with changelog / release notes announcement, I don't see the confusion concern being relevant as it'll apply to different users regardless. Aligning with Dockers documented usage makes the most sense and something we would transition to at some point anyway. We get various issues / PRs to "fix" support for versions of compose that are over 3 years old that latest releases like Debian package. You will probably experience the same either way with this change. |
I'm definitely in favor of merging this as well. I think we should be up-to-date with our main container runtime. And users having issues with this due to using outdated packages is nothing new, and IMO no reason not to update :) |
Documentation preview for this PR is ready! 🎉 Built with commit: df18fd1 |
Description
Align with upstream Docker Compose (v2). See #3289 (comment). @polarathene pinging you here just so you know. I don't want to merge this without any maintainer knowing first. Hence, pinging @casperklein here too. Marked for v13.0.0 because I consider this to be breaking.
Type of change
Checklist: