Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change if-statement style #3361

Merged

Conversation

casperklein
Copy link
Member

@casperklein casperklein commented May 23, 2023

Description

Change if-statement style from

if [[ ${#} -lt 3 ]]
then
  _log 'error' 'At least three parameters must be given'
  __usage
  exit 1
fi

to

if [[ ${#} -lt 3 ]]; then
  _log 'error' 'At least three parameters must be given'
  __usage
  exit 1
fi

Fixes #3302

Planned follow up style changes:

  • while
  • until
  • function

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein self-assigned this May 23, 2023
@casperklein casperklein marked this pull request as ready for review May 23, 2023 17:53
@casperklein casperklein added this to the v13.0.0 milestone May 23, 2023
@georglauterbach
Copy link
Member

Makes my heart bleed a bit 😝

@georglauterbach georglauterbach merged commit cf74127 into docker-mailserver:master May 24, 2023
7 checks passed
@casperklein casperklein deleted the change-if-style branch May 27, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

other: if-statement style change
3 participants