Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Revise update-and-cleanup.md #3539

Merged
merged 5 commits into from Sep 19, 2023

Conversation

jpduyx
Copy link
Contributor

@jpduyx jpduyx commented Sep 18, 2023

spotify dockergc is UNMAINTAINED, they advice to consider using docker system prune command instead.

"This repository has been archived by the owner on Feb 2, 2021. It is now read-only."

https://github.com/spotify/docker-gc

Description

Fixes #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

spotify dockergc is UNMAINTAINED, they advice to consider using docker system prune command instead.

"This repository has been archived by the owner on Feb 2, 2021. It is now read-only."

https://github.com/spotify/docker-gc
Copy link
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks for spotting this and contributing an update. I'll apply these review suggestions myself :)

@polarathene polarathene added kind/improvement Improve an existing feature, configuration file or the documentation area/documentation labels Sep 19, 2023
@polarathene polarathene added this to the v13.0.0 milestone Sep 19, 2023
@github-actions
Copy link
Contributor

Documentation preview for this PR is ready! 🎉

Built with commit: b3fbe8f

@polarathene
Copy link
Member

Before (v12.1)

image

After (v13)

image

@polarathene polarathene merged commit 8c0cfa0 into docker-mailserver:master Sep 19, 2023
3 checks passed
@polarathene polarathene changed the title Update update-and-cleanup.md docs: Revise update-and-cleanup.md Sep 19, 2023
@jpduyx jpduyx deleted the patch-1 branch September 19, 2023 06:56
@jpduyx
Copy link
Contributor Author

jpduyx commented Sep 19, 2023

thank you :-)

@polarathene polarathene mentioned this pull request Oct 16, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation kind/improvement Improve an existing feature, configuration file or the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants