Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: solve #3665 #3669

Merged
merged 4 commits into from Nov 28, 2023
Merged

hotfix: solve #3665 #3669

merged 4 commits into from Nov 28, 2023

Conversation

georglauterbach
Copy link
Member

@georglauterbach georglauterbach commented Nov 27, 2023 •
edited

Description

This patch release fixes two bugs that Rspamd users encounter on v13.0.0:

  1. The check for correct permission on the private key when signing e-mails with DKIM was flawed. The result was that a false warning was emitted.
  2. When RSPAMD_CHECK_AUTHENTICATED=0, DKIM signing for outbound e-mail was disabled, which is undesirable.

Fixes #3665

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

@georglauterbach georglauterbach added this to the v13.0.1 milestone Nov 27, 2023
@georglauterbach georglauterbach self-assigned this Nov 27, 2023
@georglauterbach georglauterbach mentioned this pull request Nov 27, 2023
Closed
1 task
polarathene
polarathene requested changes Nov 27, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
docs/content/config/environment.md Outdated Show resolved Hide resolved
mailserver.env Outdated Show resolved Hide resolved
target/rspamd/local.d/settings.conf Show resolved Hide resolved
test/tests/parallel/set1/spam_virus/rspamd_full.bats Show resolved Hide resolved
georglauterbach and others added 2 commits November 27, 2023 23:50
@georglauterbach @polarathene
Apply suggestions from code review
f331456 
Co-authored-by: Brennan Kinney <5098581+polarathene@users.noreply.github.com>
@georglauterbach
improve wording
bc59f51
@github-actions GitHub Actions
Copy link
Contributor

Documentation preview for this PR is ready! 🎉

Built with commit: bc59f51

@polarathene polarathene mentioned this pull request Nov 27, 2023
Open
polarathene
polarathene approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Improved test coverage is deferred, an existing DKIM refactor issue will track that.

@georglauterbach georglauterbach merged commit a11951e into master Nov 28, 2023
9 checks passed
@georglauterbach georglauterbach deleted the rspamd/hotfix branch November 28, 2023 09:33
@jessec jessec mentioned this pull request Nov 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polarathene polarathene polarathene approved these changes

Assignees

@georglauterbach georglauterbach

Labels
area/scripts kind/bug/fix A fix (PR) for a confirmed bug priority/high service/security/dkim-dmarc-spf service/security/rspamd
Projects
Rspamd integration
Status: Done
Milestone
v13.0.1
Development

Successfully merging this pull request may close these issues.

bug report: Test on rspamd private key files not working as expected
2 participants
@georglauterbach @polarathene