Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Logging - Welcome should use DMS_RELEASE ENV #3676

Merged
merged 4 commits into from Nov 30, 2023

Conversation

polarathene
Copy link
Member

@polarathene polarathene commented Nov 29, 2023

Description

I missed this change for #3666

This should only leave .gitattributes and .dockerignore files referencing VERSION, and VERSION file itself remaining reachable from the repo until maintainers feel comfortable with dropping support for earlier releases update-check.sh compatibility. (EDIT: Tracking issue opened)


Annnnd I just realized I didn't update VERSION myself with the release after all of this 😆

Should I add that here too? (EDIT: Added)

  • It shouldn't require a new tagged release like the previous time that happened.
  • Any release newer than v13.0.0 will now check from GH Releases thankfully.

Queued for v13.1:

  • Unless a harmless log message fix warrants another patch release 🤷‍♂️
  • The VERSION file bump will be effective without depending on publishing a new release.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change that does improve existing functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

@polarathene polarathene merged commit 68f9671 into master Nov 30, 2023
7 checks passed
@polarathene polarathene deleted the fix/version-welcome-source branch November 30, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/scripts kind/bug/fix A fix (PR) for a confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants