Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: Install arm64 rspamd from official repository #3686

Merged
merged 3 commits into from Dec 7, 2023

Conversation

p3dda
Copy link
Contributor

@p3dda p3dda commented Dec 7, 2023

scripts: Install rspamd from official repository instead of debian backports on arm64 architecture

Description

Since arm64 binary packages are available on the official respository, this may be used for arm64 architecture in favor of debian backports which contain considerably older version.

Fixes #3374

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@georglauterbach georglauterbach added area/features arch/arm64 ARM64 kind/update Update an existing feature, configuration file or the documentation service/security/rspamd labels Dec 7, 2023
@georglauterbach georglauterbach added this to the v13.1.0 milestone Dec 7, 2023
Copy link
Member

@georglauterbach georglauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thank you for the update! 3 more TODOs:

  1. I think we do not need deb-src, so we can safely remove it.
  2. Please update our docs: there is a note about the version discrepancy between AMD64 and ARM64; just remove it altogether.
  3. Please update CHANGELOG.md

target/scripts/build/packages.sh Outdated Show resolved Hide resolved
@p3dda
Copy link
Contributor Author

p3dda commented Dec 7, 2023

You are right, deb-src repository is not needed in this place, I have removed it.
CHANGELOG.md and rspamd documentation have been updated as suggested

Copy link
Contributor

github-actions bot commented Dec 7, 2023

Documentation preview for this PR is ready! 🎉

Built with commit: bdf23fe

@georglauterbach georglauterbach merged commit 77917f5 into docker-mailserver:master Dec 7, 2023
9 checks passed
@georglauterbach
Copy link
Member

This will land on :edge first and will probably go into v13.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch/arm64 ARM64 area/features kind/update Update an existing feature, configuration file or the documentation service/security/rspamd
Projects
Development

Successfully merging this pull request may close these issues.

bug report: Rspamd crash when sending or receiving
4 participants