Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Configurable number of rotated log files #3907

Merged
merged 2 commits into from Feb 28, 2024

Conversation

doominator42
Copy link
Contributor

@doominator42 doominator42 commented Feb 24, 2024

Description

Since there is the variable LOGROTATE_INTERVAL, it would be useful to be able to adjust the number of files kept by logrotate, so I added LOGROTATE_COUNT.

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary, I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

@doominator42
Copy link
Contributor Author

I was not sure about the format of the CHANGELOG, should I add a section Added with my change or add it under Updates?

@casperklein
Copy link
Member

Added is good for new features 👍

Added the environment variable LOGROTATE_COUNT (defaults to 4)
@doominator42
Copy link
Contributor Author

I added my change to the CHANGELOG, this PR is now ready for review.

@casperklein casperklein added this to the v14.0.0 milestone Feb 25, 2024
@casperklein casperklein added the kind/new feature A new feature is requested in this issue or implemeted with this PR label Feb 25, 2024
Copy link
Member

@georglauterbach georglauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

Documentation preview for this PR is ready! 🎉

Built with commit: aabea61

@georglauterbach georglauterbach merged commit 512f39c into docker-mailserver:master Feb 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/new feature A new feature is requested in this issue or implemeted with this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants