Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rspamd: minor tweaks and follow-up for SPF, DKIM and DMARC symbols #3923

Merged
merged 4 commits into from Mar 5, 2024

Conversation

georglauterbach
Copy link
Member

@georglauterbach georglauterbach commented Mar 4, 2024

Follow-up of #3913, providing only

  1. renaming of a file;
  2. two composite symbol re-definitions.

Review commit by commit.

composites.conf is important because the default policy of these composite symbols I re-defined is remove_weight, which is precisely what we do not want to happen. I noticed this issue only when looking at my Rspamd history recently; I also had to open a bug report over at rspamd/rspamd to find the root cause.

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary, I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

I originally assumed the file had to be placed into `scores.d`, but I
now know that `local.d` is actually correct.
See updates to #3690:

Additional Rspamd Symbols

Rspamd has so-called composite symbols that trigger when a condition
is met. Especially AUTH_NA and AUTH_NA_OR_FAIL will adjust the scores
of various lines in the table above. This needs to be taken into account.
polarathene
polarathene previously approved these changes Mar 5, 2024
@georglauterbach georglauterbach merged commit b5b193c into master Mar 5, 2024
2 checks passed
@georglauterbach georglauterbach deleted the rspamd/spf-dkim-dmarc-symbols branch March 5, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants