Check parameter presence

Older bundles don't have the inspect format parameter, we don't set it
for them, we set it only on bundles that define that parameter.

Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>

e2e/commands_test.go

@@ -170,7 +170,6 @@ func TestInspectApp(t *testing.T) {
 	cmd.Command = dockerCli.Command("app", "inspect", "simple-app:1.0.0")
 	cmd.Dir = dir.Path()
 	output := icmd.RunCmd(cmd).Assert(t, icmd.Success).Combined()
-	fmt.Println(output)
 	golden.Assert(t, output, "app-inspect.golden")
 
 }

internal/commands/inspect.go

@@ -42,15 +42,16 @@ func runInspect(dockerCli command.Cli, appname string, opts inspectOptions) erro
 	if err != nil {
 		return err
 	}
-	bundle, ref, err := getLocalBundle(dockerCli, bundleStore, appname, false)
+	bndl, ref, err := getLocalBundle(dockerCli, bundleStore, appname, false)
+
 	if err != nil {
 		return err
 	}
 	installation, err := appstore.NewInstallation("custom-action", ref.String())
 	if err != nil {
 		return err
 	}
-	installation.Bundle = bundle
+	installation.Bundle = bndl
 
 	driverImpl, errBuf := prepareDriver(dockerCli, bindMount{}, nil)
 	a := &action.RunCustom{
@@ -62,7 +63,9 @@ func runInspect(dockerCli command.Cli, appname string, opts inspectOptions) erro
 	if opts.pretty {
 		format = "pretty"
 	}
-	installation.Parameters[internal.ParameterInspectFormatName] = format
+
+	installation.SetParameter(internal.ParameterInspectFormatName, format)
+
 	if err := a.Run(&installation.Claim, nil, nil); err != nil {
 		return fmt.Errorf("inspect failed: %s\n%s", err, errBuf)
 	}

internal/commands/push.go

@@ -136,7 +136,7 @@ func pushInvocationImage(dockerCli command.Cli, retag retagResult) error {
 func pushBundle(dockerCli command.Cli, opts pushOptions, bndl *bundle.Bundle, retag retagResult) error {
 	insecureRegistries, err := insecureRegistriesFromEngine(dockerCli)
 	if err != nil {
-		return errors.Wrap(err, "could not retrive insecure registries")
+		return errors.Wrap(err, "could not retrieve insecure registries")
 	}
 	resolver := remotes.CreateResolver(dockerCli.ConfigFile(), insecureRegistries...)
 	var display fixupDisplay = &plainDisplay{out: os.Stdout}

internal/store/installation.go

@@ -34,6 +34,14 @@ func NewInstallation(name string, reference string) (*Installation, error) {
 	}, nil
 }
 
+// SetParameters sets the parameter value if the installation bundle has
+// a defined parameter with that name.
+func (i Installation) SetParameter(name string, value string) {
+	if _, ok := i.Bundle.Parameters[name]; ok {
+		i.Parameters[name] = value
+	}
+}
+
 var _ InstallationStore = &installationStore{}
 
 type installationStore struct {