Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

Adding zsh completion #376

Merged
merged 1 commit into from Sep 14, 2018
Merged

Conversation

silvin-lubecki
Copy link
Contributor

- What I did
Adding the zsh shell auto-completion scripts.

- How I did it

  • As suggested here I was largely inspired by kubectl. Default zsh completion generated dynamically by cobra is not really appealing (it does not complete the flags), so as kubectl, I use the bash completion scripts with some bootstrap scripts.
  • Bumped docker/cli to get a fix on long help messages

- How to verify it

$ source <(docker-app completion zsh)
$ docker-app <tab>
... it should display commands and flags...

- Description for the changelog

  • Adding zsh completion
  • Bumping docker/cli

- A picture of a cute animal (not mandatory but encouraged)

image

@chris-crone
Copy link
Member

@silvin-lubecki please rebase this

@silvin-lubecki
Copy link
Contributor Author

Yep I'm on it!

Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should hold on to merging that (i.e. the docker/cli bump) until docker/cli#1361 is merged, it will reduce a lot the number of dependencies

@vdemeester
Copy link
Contributor

@silvin-lubecki upstream PR merged, can you update vendors once again ? 👼

* Update help description and README.md

Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
@silvin-lubecki
Copy link
Contributor Author

PTAL @vdemeester

Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

Copy link
Contributor

@mnottale mnottale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnottale mnottale merged commit aef230a into docker:master Sep 14, 2018
@silvin-lubecki silvin-lubecki deleted the zsh-completion branch September 14, 2018 11:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants