Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

APP-190 -- Updated status/list output times (added 'ago' at the end) #600

Merged

Conversation

aiordache
Copy link
Contributor

Signed-off-by: Anca Iordache anca.iordache@docker.com

- What I did
Added 'ago' to the created/modified time in the status/list command output.

- How to verify it

Before:

$ docker app list
INSTALLATION APPLICATION         LAST ACTION RESULT  CREATED MODIFIED REFERENCE
hello-world  hello-world (0.1.0) install     success 3 hours 3 hours  

After:

$ docker app list
INSTALLATION APPLICATION         LAST ACTION RESULT  CREATED     MODIFIED    REFERENCE
hello-world  hello-world (0.1.0) install     success 3 hours ago 3 hours ago 

- Description for the changelog
Added 'ago' to status/list commands output times.

- A picture of a cute animal (not mandatory but encouraged)

aZLZzZV_460swp

@aiordache aiordache changed the title Updated status/list output times (added 'ago' at the end) APP-190 -- Updated status/list output times (added 'ago' at the end) Aug 27, 2019
Copy link
Member

@rumpl rumpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aiordache aiordache force-pushed the app_190_inconsistent_output_time branch 2 times, most recently from 776d543 to 497a975 Compare August 27, 2019 15:49
Signed-off-by: Anca Iordache <anca.iordache@docker.com>
@aiordache aiordache force-pushed the app_190_inconsistent_output_time branch from 497a975 to d99ac99 Compare August 28, 2019 08:48
@codecov
Copy link

codecov bot commented Aug 28, 2019

Codecov Report

Merging #600 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #600      +/-   ##
=========================================
+ Coverage   72.36%   72.4%   +0.03%     
=========================================
  Files          54      54              
  Lines        2761    2765       +4     
=========================================
+ Hits         1998    2002       +4     
  Misses        506     506              
  Partials      257     257
Impacted Files Coverage Δ
internal/commands/list.go 84.12% <100%> (+1.07%) ⬆️
internal/commands/status.go 83.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 962230a...d99ac99. Read the comment docs.

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@silvin-lubecki silvin-lubecki merged commit 964210e into docker:master Sep 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants