This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Remove support for "single file" app definition #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use of such a multi-document yaml file with required ordering is mostly confusing Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #608 +/- ##
==========================================
- Coverage 72.86% 71.44% -1.43%
==========================================
Files 53 52 -1
Lines 2849 2651 -198
==========================================
- Hits 2076 1894 -182
- Misses 504 527 +23
+ Partials 269 230 -39
Continue to review full report at Codecov.
|
silvin-lubecki
suggested changes
Sep 9, 2019
There was a problem hiding this comment.
I think that everything linked to
Line 32 in 04c3a28
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
This was referenced Mar 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Removed support for single file docker app definition. Only can use
.dockerappfolder with dedicated yaml files now- How I did it
Mostly code removal
- How to verify it
all non single-file specific tests are preserved
- Description for the changelog
"Single file" (multi document yaml) docker app definition is not supported anymore.
skipandmergecommands as well as--single-fileoption have been removed- A picture of a cute animal (not mandatory but encouraged)