This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
When none set, generate a random installation name #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #609 +/- ##
=========================================
Coverage ? 71.54%
=========================================
Files ? 51
Lines ? 2611
Branches ? 0
=========================================
Hits ? 1868
Misses ? 500
Partials ? 243
Continue to review full report at Codecov.
|
|
Is there a way to test this feature, or at least indirectly? 🤔 |
|
The description of the app/internal/commands/install.go Line 66 in e45cba1 |
ndeloof
force-pushed
the
defaultname
branch
from
6e36287
to
7f8e56c
Compare
|
@thaJeztah do you think this make sense or shall we better wait for an engine API to install apps and manage unique random name generation ? |
For uniformity with `docker run` user experience. Note a full implementation would required to get the engine manage random name unicity, like it does for containers. Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Generate a random installation name when none is set by user for uniformity with
docker runuser experience.- How I did it
Vendored dockerd namegenerator.
Clean implementation would require engine to prevent name conflicts, would make sense once we have an engine-side "deploy" implementation
- How to verify it
docker app installwithout a name, thendocker app ls- Description for the changelog
A random installation name is generated when none is passed to
docker app install.- A picture of a cute animal (not mandatory but encouraged)
