This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Remove 3rd party software integrations #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcsirot
requested review from
chris-crone and
silvin-lubecki
as code owners
There was a problem hiding this comment.
I think you left some pieces in the jenkins files https://github.com/docker/app/blob/master/Jenkinsfile.baguette#L147
jcsirot
force-pushed
the
remove-obsolete-integrations
branch
from
ce5d08e
to
2d3b0ff
Compare
…eps from codebase Signed-off-by: Jean-Christophe Sirot <jean-christophe.sirot@docker.com>
jcsirot
force-pushed
the
remove-obsolete-integrations
branch
from
2d3b0ff
to
78a90f0
Compare
|
@silvin-lubecki Indeed, I've seen it too late. PR updated |
ndeloof
approved these changes
Sep 16, 2019
Codecov Report
@@ Coverage Diff @@
## master #614 +/- ##
==========================================
- Coverage 72.73% 72.35% -0.38%
==========================================
Files 50 50
Lines 2648 2583 -65
==========================================
- Hits 1926 1869 -57
+ Misses 486 483 -3
+ Partials 236 231 -5
Continue to review full report at Codecov.
|
rumpl
approved these changes
Sep 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
3rd party software integrations have been written during the project early stage and is now obsolete and not maintained. It has to be removed from the codebase.
- How I did it
Remove the
integrationsdirectory and the related build steps in the Makefiles- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)