Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

Remove the strict flag #615

Merged
merged 1 commit into from Sep 17, 2019
Merged

Remove the strict flag #615

merged 1 commit into from Sep 17, 2019

Conversation

rumpl
Copy link
Member

@rumpl rumpl commented Sep 16, 2019

Signed-off-by: Djordje Lukic djordje.lukic@docker.com

- What I did

Removed the strict flag

- How to verify it

Run docker app install --help, there shouldn't be any --strict flags

- A picture of a cute animal (not mandatory but encouraged)
image

Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 16, 2019

Codecov Report

Merging #615 into master will decrease coverage by 0.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #615      +/-   ##
==========================================
- Coverage   72.73%   72.21%   -0.53%     
==========================================
  Files          50       50              
  Lines        2648     2573      -75     
==========================================
- Hits         1926     1858      -68     
+ Misses        486      484       -2     
+ Partials      236      231       -5
Impacted Files Coverage Δ
internal/commands/cnab.go 72.14% <ø> (-0.13%) ⬇️
internal/commands/root.go 72.22% <ø> (-0.31%) ⬇️
internal/commands/parameters.go 86.84% <ø> (-0.97%) ⬇️
internal/commands/upgrade.go 59.64% <ø> (-0.7%) ⬇️
internal/commands/install.go 66.66% <ø> (-0.46%) ⬇️
internal/packager/init.go 60.97% <0%> (-8.18%) ⬇️
types/parameters/parameters.go 92.06% <0%> (-4.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9eb813...cef9f76. Read the comment docs.

Copy link
Contributor

@jcsirot jcsirot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcsirot jcsirot merged commit 3518f0e into docker:master Sep 17, 2019
@rumpl rumpl deleted the remove-strict-flag branch October 18, 2019 08:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants