This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Dockerfile.invocation-image: Fix for multi-arch #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
approved these changes
Sep 16, 2019
ndeloof
reviewed
Sep 16, 2019
Dockerfile.invocation-image
Outdated
| @@ -1,8 +1,8 @@ | |||
| ARG ALPINE_VERSION=3.10.1 | |||
|
|
|||
| FROM dockercore/golang-cross:1.12.9@sha256:3ea9dcef4dd2c46d80445c0b22d6177817f4cfce22c523cc12a5a1091cb37705 AS build | |||
| FROM golang:1.12.9 AS build | |||
There was a problem hiding this comment.
As we want ot move to Golang 1.13, maybe you can bump version at same time ?
There was a problem hiding this comment.
I did a force-push with golang:1.13.0. Built on amd64 and arm to verify.
I'm guessing you guys already have the resources, but if you need access to aarch64 I'm sure you could get these guys to help you out: https://www.worksonarm.com/cluster/
The server they gave me was a Cavium which can't do armhf, but I've had good luck using the new AWS aarch64 instances and then running dockerd inside a 32bit LXD instance.
The container used for compiling the application is only available on amd64. This change uses a multi-arch golang container and also fixes an issue where the apt cache can be out-of-date. Fixes Bug docker#611 Signed-off-by: Ricardo Salveti <ricardo@foundries.io> Reported-by: Andy Doan <andy@foundries.io>
silvin-lubecki
approved these changes
Sep 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The container used for compiling the application is only available on
amd64. This change uses a multi-arch golang container and also fixes
an issue where the apt cache can be out-of-date.
Fixes Bug #611
Verify by building on something like an rpi3.
Signed-off-by: Ricardo Salveti ricardo@foundries.io
Reported-by: Andy Doan andy@foundries.io