This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Remove version command, introduce --version option #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
requested review from
chris-crone and
silvin-lubecki
as code owners
rumpl
reviewed
Sep 16, 2019
internal/commands/root.go
Outdated
| @@ -24,6 +27,12 @@ func NewRootCmd(use string, dockerCli command.Cli) *cobra.Command { | |||
| Use: use, | |||
| Annotations: map[string]string{"experimentalCLI": "true"}, | |||
| RunE: func(cmd *cobra.Command, args []string) error { | |||
|
|
|||
rumpl
reviewed
Sep 16, 2019
rumpl
reviewed
Sep 16, 2019
Codecov Report
@@ Coverage Diff @@
## master #619 +/- ##
=======================================
Coverage 72.29% 72.29%
=======================================
Files 51 51
Lines 2660 2660
=======================================
Hits 1923 1923
Misses 497 497
Partials 240 240Continue to review full report at Codecov.
|
ndeloof
force-pushed
the
APP-213
branch
5 times, most recently
from
34db651
to
28789cc
Compare
rumpl
reviewed
Sep 17, 2019
internal/commands/root.go
Outdated
| @@ -24,6 +27,11 @@ func NewRootCmd(use string, dockerCli command.Cli) *cobra.Command { | |||
| Use: use, | |||
| Annotations: map[string]string{"experimentalCLI": "true"}, | |||
| RunE: func(cmd *cobra.Command, args []string) error { | |||
| if showversion { | |||
rumpl
reviewed
Sep 17, 2019
internal/commands/root.go
Outdated
| @@ -24,6 +27,11 @@ func NewRootCmd(use string, dockerCli command.Cli) *cobra.Command { | |||
| Use: use, | |||
| Annotations: map[string]string{"experimentalCLI": "true"}, | |||
| RunE: func(cmd *cobra.Command, args []string) error { | |||
| if showVersion:q { | |||
There was a problem hiding this comment.
Let's pretend this never happened
chris-crone
reviewed
Sep 18, 2019
internal/commands/uninstall.go
Outdated
| @@ -20,9 +20,10 @@ func uninstallCmd(dockerCli command.Cli) *cobra.Command { | |||
| var opts uninstallOptions | |||
|
|
|||
| cmd := &cobra.Command{ | |||
| Use: "uninstall INSTALLATION_NAME [--target-context TARGET_CONTEXT] [OPTIONS]", | |||
| Use: "rm INSTALLATION_NAME [--target-context TARGET_CONTEXT] [OPTIONS]", | |||
There was a problem hiding this comment.
Was this meant to be pushed with the version change?
There was a problem hiding this comment.
seems I messed up my branches :'(
jcsirot
suggested changes
Sep 18, 2019
internal/commands/uninstall.go
Outdated
| @@ -20,9 +20,10 @@ func uninstallCmd(dockerCli command.Cli) *cobra.Command { | |||
| var opts uninstallOptions | |||
|
|
|||
| cmd := &cobra.Command{ | |||
| Use: "uninstall INSTALLATION_NAME [--target-context TARGET_CONTEXT] [OPTIONS]", | |||
There was a problem hiding this comment.
This hunk does not seem to be part of this PR
chris-crone
reviewed
Sep 18, 2019
internal/version.go
Outdated
| } | ||
|
|
||
| if Experimental == "on" { | ||
| res = append(res, fmt.Sprintf("Experimental: %s", Experimental)) |
There was a problem hiding this comment.
It might be good to be more explicit here so that people aren't confused with the CLI experimental. Maybe Experimental app build?
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
rumpl
approved these changes
Sep 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Replaced
versioncommand with a--versionoption- How I did it
Moved code around
- How to verify it
run
docker app --version- Description for the changelog
Remove version command, introduce --version option
- A picture of a cute animal (not mandatory but encouraged)
