This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Rename "uninstall" to "remove/rm" #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #622 +/- ##
=======================================
Coverage 71.83% 71.83%
=======================================
Files 51 51
Lines 2624 2624
=======================================
Hits 1885 1885
Misses 500 500
Partials 239 239Continue to review full report at Codecov.
|
rumpl
approved these changes
Sep 18, 2019
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
jcsirot
reviewed
Sep 18, 2019
| @@ -362,7 +362,7 @@ Commands: | |||
| push Push an application package to a registry | |||
| render Render the Compose file for an Application Package | |||
| status Get the installation status of an application | |||
| uninstall Uninstall an application | |||
| rm Remove an application | |||
There was a problem hiding this comment.
nit: shouldn't the commands be printed in alphabetical order in the output?
jcsirot
reviewed
Sep 18, 2019
| @@ -20,9 +20,10 @@ func uninstallCmd(dockerCli command.Cli) *cobra.Command { | |||
| var opts uninstallOptions | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Renamed
uninstallintorm(aliasremove)- How I did it
Search and replace
- How to verify it
docker app --help
docker app rm foo
- Description for the changelog
"uninstall" command renamed to "rm" (alias remove)
- A picture of a cute animal (not mandatory but encouraged)
