This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
[WIP] Build tag #632
Closed
[WIP] Build tag #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
requested review from
chris-crone and
silvin-lubecki
as code owners
ndeloof
force-pushed
the
BUILD_TAG
branch
2 times, most recently
from
3e55ed7
to
310ad08
Compare
rumpl
reviewed
Sep 24, 2019
ndeloof
force-pushed
the
BUILD_TAG
branch
2 times, most recently
from
78fd459
to
05d9228
Compare
Jenkins' BUILD_TAG allows many symbols that are not valid within docker tag Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
|
After a closer look, I notice we have Jenkins setup to build branches+PRs and the PR build actually succeed (as BUILD_TAG is then |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fix build so we can use arbitrary branch name, and more specifically dependabot support with use of
/in branch names.- How I did it
Replaced use of BUILD_TAG (=job_name-build_number) as a variable to set transient docker images tag
- How to verify it
This is what CI is made for :)
- Description for the changelog
Fix build script so we can use dependabot
- A picture of a cute animal (not mandatory but encouraged)
