This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Ux init #633
Merged
Ux init #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the UX study we remove these two flags to make init simpler. The maintainer is populated with the name of the current user. Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
The user needs to explicitly give the path to the docker-compose file that they want to base the app on. Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
rumpl
requested review from
ndeloof,
ulyssessouza,
jcsirot,
glours,
eunomie and
silvin-lubecki
ndeloof
approved these changes
Sep 24, 2019
| @@ -76,25 +77,30 @@ func TestInit(t *testing.T) { | |||
| cmd, cleanup := dockerCli.createTestCmd() | |||
| defer cleanup() | |||
|
|
|||
| userData, _ := user.Current() | |||
| currentUser := "" | |||
| if userData != nil { | |||
There was a problem hiding this comment.
nit:
var currentUser string
if userData, _ := user.Current(); userData != nil{
currentUser = userData.Username
}| ) | ||
|
|
||
| func initCmd(dockerCli command.Cli) *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "init APP_NAME [--compose-file COMPOSE_FILE] [--description DESCRIPTION] [--maintainer NAME:EMAIL ...] [OPTIONS]", | ||
| Use: "init APP_NAME [--compose-file COMPOSE_FILE] [OPTIONS]", |
There was a problem hiding this comment.
Could you rename APP_NAME with APP_DEFINITION ?
| assert.NilError(t, err) | ||
|
|
||
| data := `# Version of the application | ||
| userData, _ := user.Current() |
There was a problem hiding this comment.
Same pattern here 😅
|
Argh, I already merged it. My bad 😢 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Made UX changes to the
initsubcommand:- How I did it
Removed a bunch of code.
- How to verify it
Run
docker app init --help, the flagsdescriptionandmaintainershould no longer be there.- Description for the changelog
Docker App doesn't implicitly select a docker-compose.yml file on init.
The flags
--descriptionand--maintainerheve been removed.- A picture of a cute animal (not mandatory but encouraged)
