Remove redundant envfile #634
Remove redundant envfile #634
Conversation
Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>
5bf71d0
to
c2adac2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
still feeling uncomfortable that we rely on random commit just like things will never change after a PR has been merged
@ndeloof I know we rely on the docker/cli master branch, but we need to move on this. Moreover there will be a docker/cli release soon, and we will bump the cli then before next docker/app release 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ready to merge when green
Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>
c2adac2
to
54fa534
Compare
Codecov Report
@@ Coverage Diff @@
## master #634 +/- ##
=========================================
Coverage ? 71.95%
=========================================
Files ? 49
Lines ? 2560
Branches ? 0
=========================================
Hits ? 1842
Misses ? 486
Partials ? 232
Continue to review full report at Codecov.
|
Closes #495
- What I did
Remove redundant envfile section on render
- How I did it
By passing the option to remove it after resolving the envvars
- How to verify it
Please refer to #495 (comment) for the steps to reproduce
- Description for the changelog
Remove redundant envfile section on render
- A picture of a cute animal (not mandatory but encouraged)