Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

Remove redundant envfile #634

Merged
merged 2 commits into from Sep 27, 2019

Conversation

ulyssessouza
Copy link
Contributor

Closes #495

- What I did
Remove redundant envfile section on render

- How I did it
By passing the option to remove it after resolving the envvars

- How to verify it
Please refer to #495 (comment) for the steps to reproduce

- Description for the changelog
Remove redundant envfile section on render

- A picture of a cute animal (not mandatory but encouraged)
little-baphomet

Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulyssessouza ulyssessouza marked this pull request as ready for review September 24, 2019 13:49
Copy link
Contributor

@ndeloof ndeloof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
still feeling uncomfortable that we rely on random commit just like things will never change after a PR has been merged

@silvin-lubecki
Copy link
Contributor

@ndeloof I know we rely on the docker/cli master branch, but we need to move on this. Moreover there will be a docker/cli release soon, and we will bump the cli then before next docker/app release 👍

Copy link
Member

@rumpl rumpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ready to merge when green

Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>
@codecov
Copy link

codecov bot commented Sep 27, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@856c60a). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #634   +/-   ##
=========================================
  Coverage          ?   71.95%           
=========================================
  Files             ?       49           
  Lines             ?     2560           
  Branches          ?        0           
=========================================
  Hits              ?     1842           
  Misses            ?      486           
  Partials          ?      232
Impacted Files Coverage Δ
render/render.go 80.23% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 856c60a...54fa534. Read the comment docs.

@ulyssessouza ulyssessouza merged commit 695509b into docker:master Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.env files unpacked and also referenced (redundant)
5 participants