Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

Rename command list with ls #636

Merged
merged 1 commit into from
Sep 25, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ Commands:
init Initialize Docker Application definition
inspect Shows metadata, parameters and a summary of the Compose file for a given application
install Install an application
list List the installations and their last known installation result
ls List the installations and their last known installation result
pull Pull an application package from a registry
push Push an application package to a registry
render Render the Compose file for an Application Package
Expand Down
4 changes: 2 additions & 2 deletions e2e/commands_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ func testDockerAppLifecycle(t *testing.T, useBindMount bool) {
})

// List the installation and check the failed status
cmd.Command = dockerCli.Command("app", "list")
cmd.Command = dockerCli.Command("app", "ls")
checkContains(t, icmd.RunCmd(cmd).Assert(t, icmd.Success).Combined(),
[]string{
`INSTALLATION\s+APPLICATION\s+LAST ACTION\s+RESULT\s+CREATED\s+MODIFIED\s+REFERENCE`,
Expand Down Expand Up @@ -334,7 +334,7 @@ STATUS
})

// List the installed application
cmd.Command = dockerCli.Command("app", "list")
cmd.Command = dockerCli.Command("app", "ls")
checkContains(t, icmd.RunCmd(cmd).Assert(t, icmd.Success).Combined(),
[]string{
`INSTALLATION\s+APPLICATION\s+LAST ACTION\s+RESULT\s+CREATED\s+MODIFIED\s+REFERENCE`,
Expand Down
2 changes: 1 addition & 1 deletion e2e/pushpull_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ func TestPushPullInstall(t *testing.T) {
assert.Check(t, cmp.Contains(icmd.RunCmd(cmd).Assert(t, icmd.Success).Combined(), ref))

// listing the installed application shows the pulled application reference
cmd.Command = dockerCli.Command("app", "list")
cmd.Command = dockerCli.Command("app", "ls")
checkContains(t, icmd.RunCmd(cmd).Assert(t, icmd.Success).Combined(),
[]string{
fmt.Sprintf(`%s\s+push-pull \(1.1.0-beta1\)\s+install\s+success\s+.+second[s]?\sago\s+.+second[s]?\sago\s+%s`, t.Name(), ref+tag),
Expand Down
2 changes: 1 addition & 1 deletion e2e/testdata/plugin-usage-experimental.golden
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Commands:
init Initialize Docker Application definition
inspect Shows metadata, parameters and a summary of the Compose file for a given application
install Install an application
list List the installations and their last known installation result
ls List the installations and their last known installation result
pull Pull an application package from a registry
push Push an application package to a registry
render Render the Compose file for an Application Package
Expand Down
2 changes: 1 addition & 1 deletion e2e/testdata/plugin-usage.golden
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Commands:
init Initialize Docker Application definition
inspect Shows metadata, parameters and a summary of the Compose file for a given application
install Install an application
list List the installations and their last known installation result
ls List the installations and their last known installation result
pull Pull an application package from a registry
push Push an application package to a registry
render Render the Compose file for an Application Package
Expand Down
4 changes: 2 additions & 2 deletions internal/commands/list.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ func listCmd(dockerCli command.Cli) *cobra.Command {
var opts listOptions

cmd := &cobra.Command{
Use: "list [OPTIONS]",
Use: "ls [OPTIONS]",
Short: "List the installations and their last known installation result",
Aliases: []string{"ls"},
Aliases: []string{"list"},
Args: cli.NoArgs,
RunE: func(cmd *cobra.Command, args []string) error {
return runList(dockerCli, opts)
Expand Down