Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

Revert #626 bumping gojsonschema #638

Merged
merged 1 commit into from Sep 25, 2019

Conversation

silvin-lubecki
Copy link
Contributor

@silvin-lubecki silvin-lubecki commented Sep 25, 2019

Dependencybot only bumped the gopkg.toml and not the vendored code. It does not compile in the docker/cli code, so I prefer reverting the bump right now and fix the docker/cli code, then bump both of them.
- A picture of a cute animal (not mandatory but encouraged)

image

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "fix-gojsonschema-vendoring" git@github.com:silvin-lubecki/app.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@silvin-lubecki silvin-lubecki changed the title Fix gojsonschema vendoring Revert #626 bumping gojsonschema Sep 25, 2019
This reverts commit c4e1156.

Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #638 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #638   +/-   ##
=======================================
  Coverage   72.14%   72.14%           
=======================================
  Files          49       49           
  Lines        2542     2542           
=======================================
  Hits         1834     1834           
  Misses        479      479           
  Partials      229      229

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0093585...ff61e50. Read the comment docs.

@glours glours merged commit 3baa67c into docker:master Sep 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants