New command to list application images #639
Conversation
rumpl
requested review from
ndeloof,
ulyssessouza,
jcsirot,
eunomie and
silvin-lubecki
rumpl
force-pushed
the
feat-image-ls
branch
from
53ca93a
to
bf21fbb
Compare
Codecov Report
@@ Coverage Diff @@
## master #639 +/- ##
=========================================
Coverage ? 72.12%
=========================================
Files ? 51
Lines ? 2665
Branches ? 0
=========================================
Hits ? 1922
Misses ? 502
Partials ? 241
Continue to review full report at Codecov.
|
|
LGTM but I think we should wait for #635 to be merged and then rebase this PR. |
rumpl
force-pushed
the
feat-image-ls
branch
3 times, most recently
from
46a2606
to
e3085b2
Compare
| ) | ||
|
|
||
| func TestImageList(t *testing.T) { | ||
| runWithDindSwarmAndRegistry(t, func(info dindSwarmAndRegistryInfo) { |
There was a problem hiding this comment.
As runWithDindSwarmAndRegistry is defined in e2e/pushpull_test.go maybe we can move the method in e2e/helper_test.go. This way this test only depends on the helper and not on an other test file.
e2e/images_test.go
Outdated
|
|
||
| func TestImageList(t *testing.T) { | ||
| runWithDindSwarmAndRegistry(t, func(info dindSwarmAndRegistryInfo) { | ||
| cmd, cleanup := dockerCli.createTestCmd() |
There was a problem hiding this comment.
Why not to use cmd := info.configuredCmd? And this way the cleanup is already called by runWithDindSwarmAndRegistry
There was a problem hiding this comment.
I blindly copied the code from another test... Thanks!
internal/commands/image/list.go
Outdated
| } | ||
| return "" | ||
| }}, | ||
| {"APP NAME", func(p pkg) string { return p.bundle.Name }}, |
There was a problem hiding this comment.
nit (just to have everything written the same way):
| {"APP NAME", func(p pkg) string { return p.bundle.Name }}, | |
| {"APP NAME", func(p pkg) string { | |
| return p.bundle.Name | |
| }}, |
rumpl
force-pushed
the
feat-image-ls
branch
from
e3085b2
to
1ab9055
Compare
rumpl
force-pushed
the
feat-image-ls
branch
from
1ab9055
to
24134b9
Compare
For now we show the reference, name and version. Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
rumpl
force-pushed
the
feat-image-ls
branch
from
24134b9
to
aa2de75
Compare
For now we show the reference, name and version.
- What I did
Added a new management command
imageand a subcommandls(orlist)- How I did it
Some of the code is from this branch made by Silvin, added some more unit and e2e tests.
- How to verify it
docker app bundle myapp.dockerapp --tag myappdocker app image lsAnd you should see the application
- Description for the changelog
New subcommand
docker app image lsto list docker applications that are in the local bundle store.- A picture of a cute animal (not mandatory but encouraged)
