This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
[WIP] Proof of Concept : simpler UX not requiring a x.dockerapp folder #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
dot-dockerapp-must-die
branch
from
d4fd539
to
b6085b6
Compare
silvin-lubecki
changed the title
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
dot-dockerapp-must-die
branch
from
b6085b6
to
689a08a
Compare
ndeloof
changed the title
|
Closing. Just a PoC |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
I removed use of a x.dockerpap folder for docker apps.
Reasoning:
with
initwe copy thedocker-compose.ymlfile into dockerapp with minor changes (env variables become parameters). This duplication is weird for newcomers. Not to mention they will now have to maintain both file in sync if they don't plan to fully switch off from docker-compose.I'm convinced we can implement docker app with a plain docker-compose file just adding
parameters.yml- How I did it
Used an axe to do some refactoring. This is not much than a PoC to check this is feasible, potential side effects and the amount of code being impacted
- How to verify it
Play with it. At least e2e tests will catch most obvious regressions
- Description for the changelog
Removed need for a .dockerapp folder, can now use docker-app on a plain good old docker-compose project.
- A picture of a cute animal (not mandatory but encouraged)
