This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
remove the status command from docker app CLI #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumpl
reviewed
Sep 27, 2019
e2e/commands_test.go
Outdated
| @@ -316,36 +316,10 @@ func testDockerAppLifecycle(t *testing.T, useBindMount bool) { | |||
|
|
|||
| // Query the application status | |||
| cmd.Command = dockerCli.Command("app", "status", appName) | |||
There was a problem hiding this comment.
We can remove this too I think.
It reads weirdly for newcomers, why would we check for a random app command and look that the output is that this command is not defined?
Codecov Report
@@ Coverage Diff @@
## master #647 +/- ##
=========================================
Coverage ? 71.35%
=========================================
Files ? 48
Lines ? 2451
Branches ? 0
=========================================
Hits ? 1749
Misses ? 480
Partials ? 222
Continue to review full report at Codecov.
|
glours
force-pushed
the
remove_app_status_command
branch
from
89717de
to
da6fa10
Compare
|
There are a bunch of references to the |
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
glours
force-pushed
the
remove_app_status_command
branch
from
da6fa10
to
5a52b2f
Compare
rumpl
approved these changes
Sep 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guillaume Lours guillaume.lours@docker.com
- What I did
Remove status command from docker-app CLI
- How I did it
Remove code
- How to verify it
docker app status, check it displays- Description for the changelog
statuscommand has been removed from the CLI- A picture of a cute animal (not mandatory but encouraged)