This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Use TagNameOnly to be able to implicitly add the latest tag. #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internal/commands/image/rm.go
Outdated
| @@ -48,11 +48,12 @@ func runRm(bundleStore store.BundleStore, app string) error { | |||
| return err | |||
| } | |||
|
|
|||
| err = bundleStore.Remove(ref) | |||
| tagged := reference.TagNameOnly(ref) | |||
| err = bundleStore.Remove(tagged) | |||
There was a problem hiding this comment.
nit: if err := bundleStore.Remove(tagged); err != nil
rumpl
force-pushed
the
fix-app-image-rm
branch
from
af59bbb
to
d207549
Compare
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
rumpl
force-pushed
the
fix-app-image-rm
branch
from
d207549
to
d87c777
Compare
Codecov Report
@@ Coverage Diff @@
## master #653 +/- ##
=======================================
Coverage 71.56% 71.56%
=======================================
Files 51 51
Lines 2613 2613
=======================================
Hits 1870 1870
Misses 500 500
Partials 243 243Continue to review full report at Codecov.
|
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
rumpl
force-pushed
the
fix-app-image-rm
branch
from
1c338bb
to
747c326
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.