Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

image rm small fixes #654

Merged
merged 1 commit into from Oct 1, 2019
Merged

image rm small fixes #654

merged 1 commit into from Oct 1, 2019

Conversation

rumpl
Copy link
Member

@rumpl rumpl commented Oct 1, 2019

- What I did

  • added example usages for image rm
  • made the output nicer for the user (no domain for the reference, only repo:tag)
  • image rm adds the latest tag if none given

- A picture of a cute animal (not mandatory but encouraged)
image

Copy link
Member

@eunomie eunomie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Also add usage examples for image rm.

Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
@codecov
Copy link

codecov bot commented Oct 1, 2019

Codecov Report

Merging #654 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #654   +/-   ##
=======================================
  Coverage   72.19%   72.19%           
=======================================
  Files          51       51           
  Lines        2658     2658           
=======================================
  Hits         1919     1919           
  Misses        490      490           
  Partials      249      249

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb71be0...7814e15. Read the comment docs.

@rumpl rumpl merged commit 93e0d2b into docker:master Oct 1, 2019
@rumpl rumpl deleted the fix-app-image-rm branch October 18, 2019 08:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants