This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Docker app build #655
Merged
Docker app build #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
build
branch
2 times, most recently
from
6e3494a
to
3b49196
Compare
rumpl
reviewed
Oct 1, 2019
eunomie
reviewed
Oct 1, 2019
rumpl
reviewed
Oct 1, 2019
rumpl
reviewed
Oct 1, 2019
ndeloof
force-pushed
the
build
branch
2 times, most recently
from
b1a1885
to
6f3e3fe
Compare
ndeloof
force-pushed
the
build
branch
2 times, most recently
from
096ad10
to
2218cc1
Compare
Codecov Report
@@ Coverage Diff @@
## master #655 +/- ##
=======================================
Coverage 71.21% 71.21%
=======================================
Files 57 57
Lines 3088 3088
=======================================
Hits 2199 2199
Misses 599 599
Partials 290 290Continue to review full report at Codecov.
|
ndeloof
force-pushed
the
build
branch
5 times, most recently
from
3c708e3
to
b714187
Compare
eunomie
suggested changes
Oct 3, 2019
Code moved to packager Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
bake do offer utility functions to convert a compose file into Targets, then Targets into build.Options, but doing so it also implement compose environment variable replacement, which doesnt apply to docker app build Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
If we don't, parsing into cli/compose/types can be broken by parameters that we don't want replaced by env Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
otherwise we get a cryptic failure about 404 on grpc endpoint Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
so we don't depend on docker version installed on CI nodes Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Co-Authored-By: Yves Brissaud <yves.brissaud@gmail.com> Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Also apply recommendations from code review Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
eunomie
approved these changes
Oct 7, 2019
Comment on lines
+92
to
+99
| namedRef, err := reference.ParseNormalizedNamed(tag) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| ref, ok := reference.TagNameOnly(namedRef).(reference.NamedTagged) | ||
| if !ok { | ||
| return nil, fmt.Errorf("tag %q must be name with a tag in the 'name:tag' format", tag) | ||
| } |
There was a problem hiding this comment.
Maybe this can be replaced by reference.ParseDockerRef. It does a little more but handle the ParseNormalizedNamed + TagNameOnly
There was a problem hiding this comment.
This code actually has been moved, not created (unfortunately GH doesn't mark the full file as "new" in the diff view.
This whole thing anyway has to be revisited once we start working on "ID" as we will rely on more abstract reference.Reference an not just Named.
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
rumpl
approved these changes
Oct 7, 2019
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Introduce support for "build" in docker app relying on buildx
- How I did it
Mostly by vendoring buildx
bakecommand.bundle command has been removed as obsolete
push command has been updated
- How to verify it
includes a dedicated e2e test
- Description for the changelog
Introduce
docker app buildcommand- A picture of a cute animal (not mandatory but encouraged)
