This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Bump vendored docker/cli #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumpl
approved these changes
Oct 1, 2019
chris-crone
force-pushed
the
bump-cli-d83cd904
branch
2 times, most recently
from
6364b61
to
135c386
Compare
This allows us to rely on the upstream yaml.v2 library as it includes a mitigation for malicious YAML files (see: kubernetes/kubernetes#83253). Signed-off-by: Christopher Crone <christopher.crone@docker.com>
chris-crone
force-pushed
the
bump-cli-d83cd904
branch
from
135c386
to
90470cf
Compare
Codecov Report
@@ Coverage Diff @@
## master #657 +/- ##
==========================================
+ Coverage 71.67% 71.89% +0.22%
==========================================
Files 51 52 +1
Lines 2616 2651 +35
==========================================
+ Hits 1875 1906 +31
- Misses 498 500 +2
- Partials 243 245 +2
Continue to review full report at Codecov.
|
glours
approved these changes
Oct 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
This allows us to rely on the upstream
yaml.v2library as it includes a mitigation for malicious YAML files.Related issue: kubernetes/kubernetes#83253
- How I did it
docker/cliinGopkg.tomlmake vendor- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)