This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Fix image tag test #658
Merged
Fix image tag test #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumpl
approved these changes
Oct 2, 2019
ndeloof
approved these changes
Oct 2, 2019
eunomie
force-pushed
the
fix-image-tag-test
branch
from
f40139b
to
bcf23d9
Compare
Codecov Report
@@ Coverage Diff @@
## master #658 +/- ##
==========================================
- Coverage 72.14% 71.73% -0.42%
==========================================
Files 52 52
Lines 2675 2643 -32
==========================================
- Hits 1930 1896 -34
- Misses 497 502 +5
+ Partials 248 245 -3
Continue to review full report at Codecov.
|
Improve tests by checking the error message. Signed-off-by: Yves Brissaud <yves.brissaud@docker.com>
This allows to remove duplication and avoid to write the wrong command. Signed-off-by: Yves Brissaud <yves.brissaud@docker.com>
eunomie
force-pushed
the
fix-image-tag-test
branch
from
bcf23d9
to
eeb3270
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
docker app image tagcontains some tests where the command must fail. But the wrong command was used (and was failing, of course, so the output was the same).This PR uses the right
app image tagcommand instead of the wrongapp bundle tag.- How I did it
bundlebyimage- How to verify it
Tests are green