Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

hide render command #665

Merged
merged 1 commit into from Oct 3, 2019
Merged

Conversation

glours
Copy link
Contributor

@glours glours commented Oct 3, 2019

- What I did
Hide render command

- How I did it
pass hidden flag to true in render command

- How to verify it

  • docker app --help should not display render command
  • docker app render should display render command help
  • docker app render should behave as previously

- A picture of a cute animal (not mandatory but encouraged)

image

Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 3, 2019

Codecov Report

Merging #665 into master will decrease coverage by 0.29%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #665     +/-   ##
=========================================
- Coverage    72.1%   71.81%   -0.3%     
=========================================
  Files          57       52      -5     
  Lines        3105     2647    -458     
=========================================
- Hits         2239     1901    -338     
+ Misses        562      501     -61     
+ Partials      304      245     -59
Impacted Files Coverage Δ
internal/commands/render.go 81.25% <100%> (+0.6%) ⬆️
internal/commands/root.go 72.11% <0%> (-14.39%) ⬇️
internal/commands/push.go 45.22% <0%> (-6.75%) ⬇️
internal/compose/compose.go 74.35% <0%> (-5.13%) ⬇️
types/parameters/parameters.go 93.65% <0%> (-3.18%) ⬇️
internal/commands/build/compose.go
internal/commands/build/build.go
internal/commands/build/types.go
internal/packager/bundle.go
internal/commands/build/digest.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8504449...6b05ad1. Read the comment docs.

@silvin-lubecki silvin-lubecki merged commit 5a70445 into docker:master Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants