This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Docker app should only be used as a docker CLI plugin #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
glours
approved these changes
Oct 4, 2019
Codecov Report
@@ Coverage Diff @@
## master #667 +/- ##
=======================================
Coverage 72.07% 72.07%
=======================================
Files 52 52
Lines 2636 2636
=======================================
Hits 1900 1900
Misses 492 492
Partials 244 244Continue to review full report at Codecov.
|
ndeloof
added a commit
to ndeloof/app
that referenced
this pull request
Oct 4, 2019
follow up for docker#667 Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Removed support for docker-app-standalone and clarified installation doc
- How I did it
grep 'standalone'thenrm- How to verify it
make does not produce the standalone binary
- Description for the changelog
Docker app is only available as a docker CLI plugin
- A picture of a cute animal (not mandatory but encouraged)
