This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Digest #678
Merged
Digest #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #678 +/- ##
=======================================
Coverage 72.29% 72.29%
=======================================
Files 58 58
Lines 3140 3140
=======================================
Hits 2270 2270
Misses 581 581
Partials 289 289Continue to review full report at Codecov.
|
ndeloof
force-pushed
the
digest
branch
2 times, most recently
from
b7ccd5a
to
c039b33
Compare
rumpl
reviewed
Oct 10, 2019
rumpl
reviewed
Oct 10, 2019
rumpl
reviewed
Oct 10, 2019
rumpl
reviewed
Oct 10, 2019
rumpl
reviewed
Oct 10, 2019
ndeloof
force-pushed
the
digest
branch
3 times, most recently
from
e23c0f7
to
290ee71
Compare
silvin-lubecki
approved these changes
Oct 10, 2019
There was a problem hiding this comment.
Small nits/typos but LGTM 👍
Thank you for your patience @ndeloof 😸
jcsirot
reviewed
Oct 11, 2019
rumpl
reviewed
Oct 11, 2019
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce storage by ID (= bundle digest)
- What I did
Extended BundleStore so we both store bundles by tag and by digest, with cross references
- How I did it
bundle is now stored under
image/tag/bundle.json, aside adigestfileAt same time it's stored (duplicate) under
_digest/<digest>/bundle.json- How to verify it
Run e2e test and play with
docker app build- Description for the changelog
Allow to build docker app without a tag, image can then be referenced by a unique ID
- A picture of a cute animal (not mandatory but encouraged)
