This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Set build arg values in docker.Makefile #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zappy-shu
requested review from
chris-crone and
silvin-lubecki
as code owners
rumpl
approved these changes
Oct 10, 2019
Codecov Report
@@ Coverage Diff @@
## master #680 +/- ##
==========================================
+ Coverage 71.34% 71.37% +0.03%
==========================================
Files 56 56
Lines 2886 2886
==========================================
+ Hits 2059 2060 +1
+ Misses 563 562 -1
Partials 264 264
Continue to review full report at Codecov.
|
glours
approved these changes
Oct 10, 2019
Sets the values of the --build-args passed through to docker build from vars.mk when using make with docker.Makefile. This will correctly set the TAG so that the binary versions are set as when using the standard Makefile directly Signed-off-by: Nick Adcock <nick.adcock@docker.com>
zappy-shu
force-pushed
the
set-docker-make-build-args
branch
from
1d2e03c
to
a4c63e5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Sets the values of the --build-args passed through to docker build from vars.mk when using make with docker.Makefile. This will correctly set the TAG so that the binary versions are set as when using the standard Makefile directly.
- How I did it
Constructed
BUILD_ARGSusing variables fromvars.mk- How to verify it
Run
make -f docker.Makefile crossand ensure that theapp --versioncommand of the resulting binaries print a version (e.g.v0.6.0-516-g6a9e04b5c5-dirty) rather thanunknown- Description for the changelog
Sets build args when building with docker.Makefile