This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Align docker app with docker run UX
#681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you rename |
Codecov Report
@@ Coverage Diff @@
## master #681 +/- ##
==========================================
- Coverage 72.29% 71.78% -0.51%
==========================================
Files 58 56 -2
Lines 3140 2889 -251
==========================================
- Hits 2270 2074 -196
+ Misses 581 551 -30
+ Partials 289 264 -25
Continue to review full report at Codecov.
|
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
app can only be ran from an image built by docker app build Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
internal/commands/run.go
Outdated
| Long: longDescription, | ||
| Example: example, | ||
| Args: cli.RequiresMaxArgs(1), | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| return runInstall(dockerCli, firstOrEmpty(args), opts) | ||
| return runRun(dockerCli, firstOrEmpty(args), opts) |
There was a problem hiding this comment.
Shouldn't be firstOrEmpty(args) I think right? Now the command needs the app image reference?
There was a problem hiding this comment.
Mayeb I should rename RunForestRun ?
internal/commands/run.go
Outdated
| Aliases: []string{"deploy"}, | ||
| Short: "Install an application", | ||
| Short: "Run an application", | ||
| Long: longDescription, | ||
| Example: example, | ||
| Args: cli.RequiresMaxArgs(1), |
There was a problem hiding this comment.
Should be ExactArgs(1) ?
internal/commands/run.go
Outdated
|
|
||
| cmd := &cobra.Command{ | ||
| Use: "install [APP_NAME] [--name INSTALLATION_NAME] [--target-context TARGET_CONTEXT] [OPTIONS]", | ||
| Use: "run [APP_NAME] [--name INSTALLATION_NAME] [--target-context TARGET_CONTEXT] [OPTIONS]", |
There was a problem hiding this comment.
Use: "run [OPTIONS] APP_IMAGE" ? To better fit docker run synopsis ?
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Renamed
install/deploycommand to "run" to align withdocker runUX- How I did it
refactor > rename
- How to verify it
docker app --help
docker app run myapp
- Description for the changelog
deploycommand has been renamedrunto align withdocker runUX- A picture of a cute animal (not mandatory but encouraged)
