This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
added app labels to container metadata #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumpl
reviewed
Oct 11, 2019
ndeloof
approved these changes
Oct 11, 2019
zappy-shu
force-pushed
the
add-app-metadata-labels
branch
from
f87a3be
to
fdc8ef5
Compare
rumpl
reviewed
Oct 15, 2019
zappy-shu
force-pushed
the
add-app-metadata-labels
branch
4 times, most recently
from
f027f17
to
df1bde7
Compare
zappy-shu
force-pushed
the
add-app-metadata-labels
branch
from
df1bde7
to
bdb9d1a
Compare
zappy-shu
commented
Oct 15, 2019
zappy-shu
force-pushed
the
add-app-metadata-labels
branch
from
bdb9d1a
to
20a817e
Compare
Codecov Report
@@ Coverage Diff @@
## master #683 +/- ##
=========================================
Coverage ? 71.78%
=========================================
Files ? 56
Lines ? 2889
Branches ? 0
=========================================
Hits ? 2074
Misses ? 551
Partials ? 264
Continue to review full report at Codecov.
|
rumpl
reviewed
Oct 15, 2019
Added 2 labels to the containers when they are deployed by docker app: - com.docker.app.namespace: same as the com.docker.stack.namespace - com.docker.app.version: version of docker app used for the deploy These have been added so that Docker Desktop can differentiate between docker app deployments vs docker stack services. Signed-off-by: Nick Adcock <nick.adcock@docker.com>
zappy-shu
force-pushed
the
add-app-metadata-labels
branch
from
20a817e
to
68e3811
Compare
rumpl
approved these changes
Oct 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added 2 labels to the containers when they are deployed by docker app:
These have been added so that Docker Desktop can differentiate between docker app deployments vs docker stack services.
- How I did it
Added the labels to the services in the invocation image
installcommand (bothinstallandupgradeindocker app) before callingRunDeployon the orchestrator.- How to verify it
Assertions for the labels have been added to the e2e tests. To verify manually:
docker app installand theninspectthe running containers. They should have the labels as described above.docker app upgradeon the installed app and theninspectthe running containers. They should have the labels as described above.- Description for the changelog
Added com.docker.app.namespace and com.docker.app.version labels to containers created by docker app.
- A picture of a cute animal (not mandatory but encouraged)