Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

Demonstrate docker app build using dockercoins sample app #684

Merged
merged 1 commit into from Oct 11, 2019

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Oct 11, 2019

- What I did
Added a docker app example based on dockercoins

- How I did it
Had to tweak the docker-compose file a few

- How to verify it
run docker app build coins from the examples/dockercoins folder

- Description for the changelog
Added example dockerapp demonstrating support for build

- A picture of a cute animal (not mandatory but encouraged)
image

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #684 into master will decrease coverage by 0.94%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #684      +/-   ##
==========================================
- Coverage   72.29%   71.34%   -0.95%     
==========================================
  Files          58       56       -2     
  Lines        3140     2886     -254     
==========================================
- Hits         2270     2059     -211     
+ Misses        581      563      -18     
+ Partials      289      264      -25
Impacted Files Coverage Δ
internal/commands/build/build.go 58.26% <0%> (-7.79%) ⬇️
internal/packager/bundle.go 61.53% <0%> (-5.71%) ⬇️
types/parameters/parameters.go 92.06% <0%> (-4.77%) ⬇️
internal/commands/cnab.go 71.36% <0%> (-4.51%) ⬇️
internal/commands/install.go 65.71% <0%> (-4.5%) ⬇️
internal/commands/image/rm.go 62.5% <0%> (-1.14%) ⬇️
internal/commands/image/tag.go 89.18% <0%> (-0.56%) ⬇️
internal/store/bundle.go 73.56% <0%> (-0.54%) ⬇️
internal/store/digest.go
internal/commands/run.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58e773c...c47d4b3. Read the comment docs.

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit 7548fa2 into docker:master Oct 11, 2019
@ndeloof ndeloof deleted the build-sample branch October 11, 2019 12:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants