This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Use -trimpath while building #685
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
ndeloof
approved these changes
Oct 11, 2019
|
Build still relies on golang 1.12.9 as we use dockercore/golang-cross |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Add the new
-trimpathflag from go 1.13 which instructs the compiler to remove all file system paths from the compiled executable. With this we will see module paths in stack trace and not absolute paths. This also helps have reproducible builds (same executable bit-by-bit even if compiled on different machines).- A picture of a cute animal (not mandatory but encouraged)
