This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
add a message in install cmd when trying to pull from registry #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glours
force-pushed
the
add_message_pulling_from_registry
branch
from
f66eabf
to
e6b4d85
Compare
Codecov Report
@@ Coverage Diff @@
## master #687 +/- ##
=======================================
Coverage 71.82% 71.82%
=======================================
Files 56 56
Lines 2889 2889
=======================================
Hits 2075 2075
Misses 550 550
Partials 264 264Continue to review full report at Codecov.
|
rumpl
reviewed
Oct 14, 2019
internal/commands/cnab.go
Outdated
| @@ -293,6 +293,7 @@ func getBundle(dockerCli command.Cli, bundleStore appstore.BundleStore, name str | |||
| if err != nil { | |||
| fmt.Fprintf(dockerCli.Err(), "Unable to find application image %q locally\n", reference.FamiliarString(ref)) | |||
|
|
|||
| fmt.Fprintf(dockerCli.Out(), "Pulling from registry…\n") | |||
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
glours
force-pushed
the
add_message_pulling_from_registry
branch
from
e6b4d85
to
f4dfec5
Compare
rumpl
approved these changes
Oct 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Add a message saying we're pulling from the registry when an app isn't find in the local bundle store
- How I did it
Print the message in the standard output of the CLI
- How to verify it
try to pull an unknown image & check the output is like that
- A picture of a cute animal (not mandatory but encouraged)
