This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Add the docker app version in the bundle #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "testing" | ||
|
|
||
| "github.com/docker/app/internal" |
There was a problem hiding this comment.
Import order is weird 🤔
rumpl
force-pushed
the
feat-docker-app-version-custom
branch
from
02f5645
to
4509275
Compare
Codecov Report
@@ Coverage Diff @@
## master #692 +/- ##
==========================================
+ Coverage 71.74% 71.82% +0.08%
==========================================
Files 56 56
Lines 2884 2889 +5
==========================================
+ Hits 2069 2075 +6
+ Misses 551 550 -1
Partials 264 264
Continue to review full report at Codecov.
|
This will help us track what we can or not do with the bundle we are dealing with. Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
rumpl
force-pushed
the
feat-docker-app-version-custom
branch
from
4509275
to
37b6193
Compare
glours
approved these changes
Oct 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added the docker app version in the generated bundle. This will help us track what we can or not do with the bundle we are dealing with.
- How to verify it
custom["com.docker.app.version"].- A picture of a cute animal (not mandatory but encouraged)
