Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

Remove unused exported functions/variables #696

Merged
merged 1 commit into from Oct 17, 2019

Conversation

rumpl
Copy link
Member

@rumpl rumpl commented Oct 16, 2019

- What I did

Removed some unused code

- A picture of a cute animal (not mandatory but encouraged)
image

Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 16, 2019

Codecov Report

Merging #696 into master will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #696      +/-   ##
==========================================
+ Coverage   71.65%   71.88%   +0.23%     
==========================================
  Files          56       56              
  Lines        2889     2885       -4     
==========================================
+ Hits         2070     2074       +4     
+ Misses        554      547       -7     
+ Partials      265      264       -1
Impacted Files Coverage Δ
types/types.go 87.5% <ø> (+2.24%) ⬆️
internal/names.go 100% <ø> (ø) ⬆️
types/parameters/parameters.go 92.06% <0%> (+6.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f1a594...741d50f. Read the comment docs.

@ndeloof ndeloof merged commit 175bec6 into docker:master Oct 17, 2019
@rumpl rumpl deleted the refactor-remove-unused branch October 18, 2019 08:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants