This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Also tag invocation image unknown so we can run e2e tests in Goland
#698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
So I can run e2e tests from Golang I have to change
version.goto point to current git commit (this is handled by Makefile for classic build, but no within IDE)And then I already created PRs with this change committed a few time - too much times actually
I changed the build so it also tag the invocation image as
unknown, so e2e test can run from Goland without Makefile hacks, without impacting the standard build- How I did it
invocation image is tagged both with git status and as
unknown- How to verify it
Use Goland :P
- Description for the changelog
_
- A picture of a cute animal (not mandatory but encouraged)
