This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Introduce --iidfile option #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumpl
previously requested changes
Oct 22, 2019
ndeloof
force-pushed
the
APP-298
branch
5 times, most recently
from
47816e4
to
9e662b2
Compare
ndeloof
force-pushed
the
APP-298
branch
4 times, most recently
from
d53a39f
to
29f299f
Compare
glours
approved these changes
Oct 22, 2019
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #705 +/- ##
=======================================
Coverage 71.02% 71.02%
=======================================
Files 59 59
Lines 2975 2975
=======================================
Hits 2113 2113
Misses 580 580
Partials 282 282Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Introduce
--iidfileoption to store built app image ID in a file- How I did it
Copy pasted option from the docker CLI
- How to verify it
run
docker app build --iidfile foo .foofile contains a single line with image ID, matching the one reported on console at the end of the build.- Description for the changelog
Introduce
--iidfileoption to store built app image ID in a file- A picture of a cute animal (not mandatory but encouraged)
