Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

Picture of animal in PR should really be optional #722

Merged
merged 1 commit into from Nov 4, 2019

Conversation

eunomie
Copy link
Member

@eunomie eunomie commented Oct 30, 2019

Because it's only folklore and should not be a blocker.

- What I did

Just removed the but encouraged about picture of animal in PR template

- How I did it

- How to verify it

- Description for the changelog

Because it's only folklore and should not be a blocker.

Signed-off-by: Yves Brissaud <yves.brissaud@docker.com>
@codecov
Copy link

codecov bot commented Oct 30, 2019

Codecov Report

Merging #722 into master will decrease coverage by 1.48%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #722      +/-   ##
==========================================
- Coverage   72.45%   70.96%   -1.49%     
==========================================
  Files          59       59              
  Lines        3438     3031     -407     
==========================================
- Hits         2491     2151     -340     
+ Misses        612      589      -23     
+ Partials      335      291      -44
Impacted Files Coverage Δ
internal/commands/run.go 60.22% <0%> (-9.86%) ⬇️
internal/commands/remove.go 52% <0%> (-8.57%) ⬇️
internal/store/bundle.go 68.93% <0%> (-7.75%) ⬇️
internal/commands/update.go 58.18% <0%> (-7.21%) ⬇️
internal/cnab/cnab.go 63.33% <0%> (-6.24%) ⬇️
internal/commands/image/list.go 83.33% <0%> (-5.82%) ⬇️
types/parameters/parameters.go 92.06% <0%> (-4.77%) ⬇️
internal/commands/push.go 45.22% <0%> (-2.57%) ⬇️
internal/commands/image/tag.go 88.88% <0%> (-1.31%) ⬇️
internal/store/digest.go 86.36% <0%> (-0.82%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6267dc4...03792ed. Read the comment docs.

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, encouraged is not a blocker... And it's explicit that it's not mandatory.

@eunomie
Copy link
Member Author

eunomie commented Oct 30, 2019

Well, encouraged is not a blocker...

Yep, blocker is maybe too strong.

And it's explicit that it's not mandatory.

Yes, but it's explicit that is encouraged and I don't think it's necessary.

@rumpl
Copy link
Member

rumpl commented Oct 30, 2019

Could you add some tests? The coverage seems to go down with this PR

@rumpl rumpl merged commit 447dd10 into docker:master Nov 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants